fix INT128_MIN write #1152
Open
fix INT128_MIN write #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1152 +/- ##
==========================================
- Coverage 90.47% 89.99% -0.48%
==========================================
Files 9 8 -1
Lines 2319 2288 -31
==========================================
- Hits 2098 2059 -39
- Misses 221 229 +8 ☔ View full report in Codecov by Sentry. |
nhz2
reviewed
Jan 3, 2025
|
This breaks writing df = DataFrame(a = BigInt[])
push!(df, [big(-170141183460469231731687303715884105728)])
CSV.write("a.csv", df)
ERROR: MethodError: no method matching Unsigned(::BigInt)
The type `Unsigned` exists, but no method is defined for this combination of argument types when trying to construct it. |
Co-authored-by: Nathan Zimmerberg <[email protected]>
nhz2
reviewed
Jan 6, 2025
test/write.jl
Outdated
Comment on lines
199
to
204
| # 1151 | ||
| ( | ||
| [(a=Int128(-170141183460469231731687303715884105728),)], | ||
| NamedTuple(), | ||
| "a\n-170141183460469231731687303715884105728\n" | ||
| ) |
There was a problem hiding this comment.
It would be good to add a test with BigInt as well to avoid future regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes #1151