Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsontable(x::AbstractVector{<:JSON3.Object}) #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anandijain
Copy link

@quinnj

This PR making me realize I'm bad at type parameters, I think we still want the jsontable(x::JSON3.Array) dispatch that I commented out.

Should I make it jsontable(x::JSON3.Array{Any}) or something?

Thanks

@quinnj
Copy link
Member

quinnj commented Oct 6, 2022

I think just uncommenting it should be fine? Were you seeing issues not specifying a type paramter?

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 91.57% // Head: 92.55% // Increases project coverage by +0.97% 🎉

Coverage data is based on head (c6fac42) compared to base (239f4f2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   91.57%   92.55%   +0.97%     
==========================================
  Files           1        1              
  Lines          95       94       -1     
==========================================
  Hits           87       87              
+ Misses          8        7       -1     
Impacted Files Coverage Δ
src/JSONTables.jl 92.55% <100.00%> (+0.97%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants