Wrap result of tracktime in a struct #142
Conversation
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
=======================================
Coverage 59.93% 59.93%
=======================================
Files 18 18
Lines 1258 1258
=======================================
Hits 754 754
Misses 504 504
Continue to review full report at Codecov.
|
src/ml.jl
Outdated
| delayedmap(x -> schema(x, $T), xs.chunks))) | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Ah. I'd forgotten that I had that one floating around. It doesn't belong here but there is (maybe was) actually an ambiguity when I tried to using schema in the distributed case.
and avoid unconditional printing of timing results
andreasnoack
force-pushed
the
anj/tracktime
branch
from
0eaaea1 to
b78440f
Compare
| @@ -84,6 +84,12 @@ function stop_tracking_time() | |||
| compute_context[] = nothing | |||
| end | |||
|
|
|||
| struct TrackTime | |||
| obj | |||
There was a problem hiding this comment.
This is actually an NDSparse object -- this is quite useful to filter timings for specific steps (e.g. comm / compute) or specific processes. It would be nice to make a note of how to get to this in the printing? Once taken out, the NDSparse has to be wrapped again in this type to display as it does...
Possible fix of #140