Get test suite passing tests again #389
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @jpsamaroo , this needs JuliaParallel/Dagger.jl#208 to pass |
|
Ah, looks like we have some Julia 1.0 compatibility issues here w/ the reduce stuff. Ugh. |
|
Just drop support for <1.3? 1.0 users probably won't be able to get recent versions of various packages anyway. Once 1.7 is released, I'm going to lower-bound Julia to at least 1.3 in Dagger. |
|
Yeah, good idea; just pushed that, let's see what CI thinks. |
|
How is it going now? |
matteorossini
added a commit
to Electa-Git/FlexPlan.jl
that referenced
this pull request
Mar 24, 2022
This commit deletes: - code that depends on JuliaDB; - code related to reliability analysis; - code that is no longer used after previous deletions. JuliaDB is basically unmaintained (latest release is one year and a half ago; multiple blocking issues refer to <JuliaData/JuliaDB.jl#389> which is stale) and cannot be used together with the other dependencies due to unsatisfiable version requirements. Substituting JuliaDB with DataFrames would entail a complete rewrite in most cases. The code related to reliability analysis has not kept up with the updates made in the repository in the last year (such as adding dimensions, new problem functions, investment constraints specified only once a year rather than for all hours...). Any code deleted here can of course be restored when someone is willing to update it.
Heptazhou
pushed a commit
to Heptazhou/JLdb.jl
that referenced
this pull request
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.