Skip to content

Disable avx2/sse3/clmul if we don't specifically ask for a native CPU target#7

Merged
Drvi merged 4 commits intomainfrom
td-conservative-codegen
Aug 10, 2023
Merged

Disable avx2/sse3/clmul if we don't specifically ask for a native CPU target#7
Drvi merged 4 commits intomainfrom
td-conservative-codegen

Conversation

@Drvi
Copy link
Copy Markdown
Collaborator

@Drvi Drvi commented Aug 10, 2023

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -3.08% ⚠️

Comparison is base (e4f85ce) 93.85% compared to head (ad86dfc) 90.78%.

❗ Current head ad86dfc differs from pull request most recent head bebd761. Consider uploading reports for the commit bebd761 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   93.85%   90.78%   -3.08%     
==========================================
  Files           1        1              
  Lines         228      228              
==========================================
- Hits          214      207       -7     
- Misses         14       21       +7     
Files Changed Coverage Δ
src/NewlineLexers.jl 90.78% <ø> (-3.08%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@nickrobinson251 nickrobinson251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

should we document this ENV var somewhere? maybe in the README

@Drvi Drvi changed the title Disable avx2/sse3/clmul if JULIA_CPU_TARGET is not native Disable avx2/sse3/clmul if we don't specifically ask for a native CPU target Aug 10, 2023
@Drvi Drvi merged commit 4f3ec84 into main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants