Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buffer overflow for Julia >=1.11 in mpfr_strtofr #193

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix buffer overflow for Julia >=1.11 in mpfr_strtofr #193

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd34363
Fix buffer overflow for Julia >=1.11 in `mpfr_strtofr`
Zentrik Oct 26, 2024
f3d722d
Actually convert to Cstring
Zentrik Oct 26, 2024
b1f6471
Prevent `String` mutating buffer
Zentrik Oct 26, 2024
a651e2f
Copy correctly and only when necessary
Zentrik Oct 26, 2024
d4f3df9
Copy `Memory` on Julia 1.11
Zentrik Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/floats.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,13 @@
readbytes!(source, str, vlen)
fastseek!(source, _pos) # reset IO to earlier position
end
@static if v"1.11-" <= VERSION < v"1.12-"

Check warning on line 75 in src/floats.jl

View check run for this annotation

Codecov / codecov/patch

src/floats.jl#L75 

Added line #L75 was not covered by tests
str = (str isa Vector{UInt8} || str isa Memory{UInt8}) ? copy(str) : str
else
str = (str isa Vector{UInt8}) ? copy(str) : str
end

str = Base.cconvert(Cstring, String(str))
GC.@preserve str begin
ptr = pointer(str, strpos)
endptr = Ref{Ptr{UInt8}}()
Expand Down
Loading