Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve ambiguities #86

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Resolve ambiguities #86

wants to merge 17 commits into from

Commits on Mar 15, 2023

  1. Switch to using retest for faster development. 

    Undone autoformat in rebase.
    @KeithWM
    KeithWM committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    cfe75ee View commit details
    Browse the repository at this point in the history

  2. Added tests known to fail on current implementation.

    @KeithWM
    KeithWM committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    ca220d4 View commit details
    Browse the repository at this point in the history

  3. Fixed some of the broken tests to be properly broken.

    @KeithWM
    KeithWM committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    ed6ce80 View commit details
    Browse the repository at this point in the history

  4. Added BigInt along Integer in the definition of several comparisons for 

    ChainedVectorIndex.
    @KeithWM
    KeithWM committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d5588a1 View commit details
    Browse the repository at this point in the history

  5. Also define Base.reduce for hcat and vcat. 

    Undone autoformat in rebase.
    @KeithWM
    KeithWM committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    67d948a View commit details
    Browse the repository at this point in the history

  6. Implemented methods for removing ambiguity in hcat and vcat.

    @KeithWM
    KeithWM committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    8cc04a8 View commit details
    Browse the repository at this point in the history

  7. Made broadcast test work as expected.

    @KeithWM
    KeithWM committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    25beb56 View commit details
    Browse the repository at this point in the history

  8. Reserve behaviour of Base.Broadcast.broadcasted(s::S, c::ChainedVector) 

    where {S<:Base.Broadcast.BroadcastStyle}.
Too difficult to know what to do.
    @KeithWM
    KeithWM committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d49c10b View commit details
    Browse the repository at this point in the history

  9. Fixed copyto! with a PermutedDimsArray{Any, 1}

    @KeithWM
    KeithWM committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    0a7dd11 View commit details
    Browse the repository at this point in the history

  10. Added comment explaning that one test is maybe NOT our responsibility.

    @KeithWM
    KeithWM committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    09e01a9 View commit details
    Browse the repository at this point in the history

  11. Fixed findall(Fix2{typeof(in)}, ::ChainedVector) ambiguity.

    @KeithWM
    KeithWM committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    8ea444c View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Version bumped Julia to 1.6

    @KeithWM
    KeithWM committed May 23, 2023
    Configuration menu
    Copy the full SHA
    7776fc4 View commit details
    Browse the repository at this point in the history

  2. Added a test to cover the case of copyto!(::AbstractVector, 

    ::Union{Signed, Unsigned}, ::ChainedVector}
    @KeithWM
    KeithWM committed May 23, 2023
    Configuration menu
    Copy the full SHA
    8a279a1 View commit details
    Browse the repository at this point in the history

  3. Included a test case for the broadcasting of a ChainedVector

    @KeithWM
    KeithWM committed May 23, 2023
    Configuration menu
    Copy the full SHA
    e7f1767 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Removed duplicated deleteat! testset.

    @KeithWM
    KeithWM committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    9ae27d9 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2023

  1. Merge pull request #1 from JuliaData/main 

    Track fork origin
    @KeithWM
    KeithWM authored Jun 3, 2023
    Configuration menu
    Copy the full SHA
    6ec2e5b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into resolve-ambiguities-without-autoformat 

    Required manual merge of runtests, as the newly included
BufferedVectors' tests were added there, but must now be in the
SentinelArraysTests module.
    @KeithWM
    KeithWM committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    b6af311 View commit details
    Browse the repository at this point in the history