Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tables interface to RowIterator #126

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Conversation

tkf
Copy link
Contributor

@tkf tkf commented Dec 16, 2019

This PR turns RowIterator into a proper table. It came up in JuliaData/TypedTables.jl#57 to support semantically row-oriented append! with column-oriented memory access for optimization. The idea is to use append!(dest, Tables.row(src)) to declare that you are adding rows in src to dest even when iterate(src) is not defined for column-wise. Example usage is: append!(Table(a=[1], b=[2]), Tables.rows((a=[3], b=[4]))).

@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #126 into master will decrease coverage by 0.64%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   96.51%   95.87%   -0.65%     
==========================================
  Files           7        7              
  Lines         430      436       +6     
==========================================
+ Hits          415      418       +3     
- Misses         15       18       +3
Impacted Files Coverage Δ
src/fallbacks.jl 95.04% <50%> (-2.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de50b30...7beda30. Read the comment docs.

@quinnj quinnj merged commit 59de960 into JuliaData:master Dec 16, 2019
@tkf tkf deleted the rowiterator-table branch December 16, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants