Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace kwargs.data with values(kwargs). #109

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Replace kwargs.data with values(kwargs). #109

merged 1 commit into from
Feb 11, 2023

Conversation

dmbates
Copy link
Contributor

@dmbates dmbates commented Feb 11, 2023

Per comment in #108

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Base: 69.08% // Head: 69.12% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (cfdd14e) compared to base (5e69b5a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   69.08%   69.12%   +0.03%     
==========================================
  Files           7        7              
  Lines         909      910       +1     
==========================================
+ Hits          628      629       +1     
  Misses        281      281              
Impacted Files Coverage Δ
src/FlexTable.jl 80.60% <100.00%> (ø)
src/TypedTables.jl 90.90% <0.00%> (+0.90%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmbates
Copy link
Contributor Author

dmbates commented Feb 11, 2023

The changes in Project.toml just reorder the lines. I believe this was done automatically by an update of the package with a recent version of Julia. I can revert that file if desired.

I'm not sure about the test failure Julia-v1.0.5. I only tested back to the lts version.

@quinnj quinnj merged commit 5fd8ff2 into main Feb 11, 2023
@quinnj quinnj deleted the kwargs_warning branch February 11, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants