Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve iteration for multiple documents in one file. #120

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improve iteration for multiple documents in one file. #120

wants to merge 5 commits into from

Commits on Aug 8, 2024

  1. Add more iteration tests

    @contradict
    contradict committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    8bbcc72 View commit details
    Browse the repository at this point in the history

  2. Complete iteration protocol.

    @contradict
    contradict committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    03e4c59 View commit details
    Browse the repository at this point in the history

  3. Do not close file before iterator reads data.

    @contradict
    contradict committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    67dd8dd View commit details
    Browse the repository at this point in the history

  4. Read the whole file into memory 

    when parsing multi-document files. Since parsing is lazy, just using
`do` results in the file being closed before parsing happens. Leaving
the file open and wating for the finalizer to close it was deemed
undesirable.
    @contradict
    contradict committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    566c4fa View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Combine duplicated IteratorSize implementation, add comment

    @contradict
    contradict committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    b13ddde View commit details
    Browse the repository at this point in the history