-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Not Urgent, Stylistic] Add newlines in long function definitions in src/YAML.jl
.
#180
base: master
Are you sure you want to change the base?
Conversation
src/YAML.jl
.src/YAML.jl
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a style I like at all, rather the opposite, but I'm not the maintainer.
load( | ||
ts::TokenStream, | ||
more_constructors::_constructor=nothing, | ||
multi_constructors::Dict=Dict(); | ||
dicttype::_dicttype=Dict{Any, Any}, | ||
constructorType::Function=SafeConstructor, | ||
) = load( | ||
ts, | ||
constructorType(_patch_constructors(more_constructors, dicttype), multi_constructors), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
load( | |
ts::TokenStream, | |
more_constructors::_constructor=nothing, | |
multi_constructors::Dict=Dict(); | |
dicttype::_dicttype=Dict{Any, Any}, | |
constructorType::Function=SafeConstructor, | |
) = load( | |
ts, | |
constructorType(_patch_constructors(more_constructors, dicttype), multi_constructors), | |
) | |
function load(ts::TokenStream, more_constructors::_constructor=nothing, multi_constructors::Dict=Dict(); | |
dicttype::_dicttype=Dict{Any, Any}, constructorType::Function=SafeConstructor) | |
load(ts, constructorType(_patch_constructors(more_constructors, dicttype), multi_constructors) | |
end |
I really dislike this as well. I'd be open to a newline on kwargs or something for these (I showed an example above), but in that case, I think I'd want a |
No description provided.