Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peek1(::BufferedInput, ::Integer) as 1-based indexing peek function #209

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Paalon
Copy link
Contributor

@Paalon Paalon commented Jun 17, 2024

This depends on #208. Prepare peek1 function for readability.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.52%. Comparing base (8a64959) to head (5577192).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   87.37%   87.52%   +0.15%     
==========================================
  Files          12       12              
  Lines        1639     1547      -92     
==========================================
- Hits         1432     1354      -78     
+ Misses        207      193      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Paalon Paalon changed the title [No Breaking] Refactoring of src/buffered_input.jl part 2 Add peek1(::BufferedInput, ::Integer) as 1-based indexing peek function Jun 21, 2024
Copy link
Collaborator

@kescobo kescobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants