Skip to content

Conversation

@perchouli
Copy link

  • Added RedisClusterConnection type and cluster-specific command implementations
  • Implemented CRC16-based slot calculation for Redis Cluster key distribution
  • Added special handling for multi-key commands (mget, mset, del, etc.) to work across different slots
  • Created CLUSTER_MULTI_KEY_COMMANDS set to identify commands needing cluster-specific logic
  • Added cluster-aware implementations for key management commands (keys, rename, random

@jkaye2012
Copy link
Collaborator

Hey, thanks for the PR.

I don't really have any concerns with the implementation, but I think the tests should be improved before we consider moving forward with it. Minimally, we'd want the test suite to spin up a local cluster and execute the cluster-specific commands against the cluster.

From the attempted CI run, it looks like the actions/cache version needs to be updated as well - I think that should be a simple version bump.

- Added Redis cluster support with specialized handling for multi-key operations
- Implemented CRC16 slot calculation and key distribution logic for cluster operations
- Added special implementations for cluster commands (mget, mset, del, keys, etc.)
- Updated CI workflow to test against Redis cluster and nightly Julia builds
- Upgraded GitHub Actions dependencies (checkout@v4, cache@v4)
- Added hosts file configuration for TLS testing
@perchouli
Copy link
Author

Thanks for the feedback.

I've fixed the tests for 1.6/1.
For the nightly build, there are failures caused by other dependencies, so I’ve configured it to continue-on-error.

ERROR: LoadError: Precompiled image Base.PkgId(Base.UUID("399d05d3-28fc-5cf5-932b-b3ee5b53232d"), "CompatLinearAlgebraExt") not available with flags CacheFlags(; use_pkgimages=true, debug_level=1, check_bounds=1, inline=true, opt_level=2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants