Skip to content

Conversation

wsmoses
Copy link
Contributor

@wsmoses wsmoses commented Sep 12, 2025

…derivative) or nan

step size is calculated based of the initial derivatives of all results. However, if some of the results return nan and/or are non-determinstic, the step size will be inf/nan, causing all other results to be broken -- instead of just the result which is expected to have an inf/nan derivative

cc @vchuravy @giordano

@wsmoses
Copy link
Contributor Author

wsmoses commented Sep 12, 2025

relatedly @oscardssmith can we add EnzymeTestUtils as reverse CI here too [as I see ChainRulesTestUtils as such a a reverse CI]

@oscardssmith
Copy link
Member

I would defer on CI decisions to someone more deeply involved in this package.

@wsmoses
Copy link
Contributor Author

wsmoses commented Sep 12, 2025

fair and yeah can follow up later on that.

ci chainrules error is unrelated

@oscardssmith
Copy link
Member

I'm not aware of who actually has merge rights here. Looks like the most recent PRs merged were last year by @oxinabox, and @wesselb, so presumably this should get a review from one of them.

@oxinabox oxinabox merged commit 3b7ac6d into JuliaDiff:main Sep 13, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants