Add fast path for forwarddiff_color_jacobian! with sparse J #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial fix for #138 Bodges in a fast path for the case where J and sparsity are are both SparseMatrixCSC and have the same number of columns and stored values.
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
==========================================
+ Coverage 83.05% 83.10% +0.05%
==========================================
Files 12 12
Lines 667 669 +2
==========================================
+ Hits 554 556 +2
Misses 113 113
Continue to review full report at Codecov.
|
This was referenced Jul 18, 2021
| @@ -316,3 +333,17 @@ function forwarddiff_color_jacobian!(J::AbstractMatrix{<:Number}, | |||
| end | |||
| return J | |||
| end | |||
|
|
|||
| # fast version of FiniteDiff._colorediteration! for the case where J and sparsity have the same sparsity pattern | |||
| @inline function _colorediteration!(Jsparsity::SparseMatrixCSC,vfx,colorvec,color_i,ncols) | |||
There was a problem hiding this comment.
Shouldn't this just go to FiniteDiff.jl?
There was a problem hiding this comment.
|
OK done... now requires PR JuliaDiff/FiniteDiff.jl#124 (however admit I don't fully understand how this could work and might be proliferating cut-and-paste cases instead of sane dispatches). Now we have:
|
Simplifies fast path logic. All other cases (J is not a SparseMatrixCSC, or J has a different sparsity pattern) use previous slow path.
|
Add a lower bound on 2.8.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #138 #100
Add a fast path for the case where J and sparsity are are both SparseMatrixCSC
and have the same sparsity pattern.