Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
have update_coeffs(L::ADVecProd,) recursively update L.f #232
have update_coeffs(L::ADVecProd,) recursively update L.f #232
Changes from 12 commits
59b5c76
c20400a
82eee1a
3f73643
9036932
0b3241a
530e1b2
7e4ac73
c71b336
0c6f6fd
b5e2fe3
6cd7300
f3719de
1f8274f
c126bf8
c8b45c0
57f4a55
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vpuri3 can you take a look at how this operator is using
u
as part of its state, and applying it to a different RHSv
? Is this something that is invalid in your opinion? Because your recent changes don't work with this -- this also relates to the discussion in SciML/SciMLOperators.jl#57.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This is a separate, SciMLOperators issue, so resolved for our purposes here)