-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
have update_coeffs(L::ADVecProd,) recursively update L.f #232
Merged
Merged
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
59b5c76
update_coeffs(L::ADVecProd,...) will recursively call update_coeffs(L…
vpuri3 c20400a
Add tests for recursive updates of f in JacVec etc.
gaurav-arya 82eee1a
Update VecJac to new f signature
gaurav-arya 3f73643
Test VecJac too
gaurav-arya 9036932
Add missing file
gaurav-arya 0b3241a
use new (u, p, t) in autofwdmode
vpuri3 530e1b2
Fix typo
gaurav-arya 7e4ac73
Remove u-dependence in WrapFunc
gaurav-arya c71b336
Make sure to reset state of stateful functions when reconstructing op…
gaurav-arya 0c6f6fd
Revert commenting out tests
gaurav-arya b5e2fe3
Update WrapFunc in vecjac tests
gaurav-arya 6cd7300
Remove update_coefficients_for_test!, test L(v, u, p, t)
gaurav-arya f3719de
Remove update_coefficients calls in operator evaluation
gaurav-arya 1f8274f
Introduce nonlinearities into test funcs
gaurav-arya c126bf8
Fix aliasing of x and v in tests, as well as unreverted edits to x in…
gaurav-arya c8b45c0
Tighten up a few more tolerances
gaurav-arya 57f4a55
Revert extraneous change to out-of-place zygote hessian
gaurav-arya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisRackauckas that this was not done before seems to actually have been a fairly serious numerical error: the vector x where the Jacobian is being evaluated at gets edited by around sqrt(eps) each time the Jacobian is applied, if I am thinking this through correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, not Jacobian; this error was only present for (finite difference computed) Hessians