Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #235

Merged
merged 11 commits into from
Mar 28, 2023
Merged

Fix CI #235

merged 11 commits into from
Mar 28, 2023

Conversation

gaurav-arya
Copy link
Contributor

@gaurav-arya gaurav-arya commented Mar 27, 2023

Resolves #234. Fixes various typos that crept in when CI was disabled

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +82.30 🎉

Comparison is base (f191085) 0.21% compared to head (7e41089) 82.52%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #235       +/-   ##
===========================================
+ Coverage    0.21%   82.52%   +82.30%     
===========================================
  Files          14       14               
  Lines         929      944       +15     
===========================================
+ Hits            2      779      +777     
+ Misses        927      165      -762     
Impacted Files Coverage Δ
ext/SparseDiffToolsZygote.jl 82.85% <100.00%> (+82.85%) ⬆️
src/differentiation/jaches_products.jl 95.83% <100.00%> (+95.83%) ⬆️

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vpuri3 vpuri3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisRackauckas there's some ArrayInterface/ StaticArrays bug here. can you take a look?

@vpuri3
Copy link
Contributor

vpuri3 commented Mar 27, 2023

https://github.com/JuliaDiff/SparseDiffTools.jl/actions/runs/4537212339/jobs/7994820746?pr=235#step:6:389

  LoadError: MethodError: no method matching Float64(::ForwardDiff.Dual{ForwardDiff.Tag{typeof(Main.##280.staticf), Float64}, Float64, 3})
  Closest candidates are:
    (::Type{T})(::Real, ::RoundingMode) where T<:AbstractFloat at rounding.jl:200
    (::Type{T})(::T) where T<:Number at boot.jl:760
    (::Type{T})(::AbstractChar) where T<:Union{AbstractChar, Number} at char.jl:50
    ...
  Stacktrace:
    [1] convert(#unused#::Type{Float64}, x::ForwardDiff.Dual{ForwardDiff.Tag{typeof(Main.##280.staticf), Float64}, Float64, 3})
      @ Base ./number.jl:7
    [2] macro expansion
      @ ~/.julia/packages/StaticArraysCore/U2Z1K/src/StaticArraysCore.jl:81 [inlined]
    [3] convert_ntuple
      @ ~/.julia/packages/StaticArraysCore/U2Z1K/src/StaticArraysCore.jl:77 [inlined]
    [4] StaticArraysCore.SVector{30, Float64}(x::NTuple{30, ForwardDiff.Dual{ForwardDiff.Tag{typeof(Main.##280.staticf), Float64}, Float64, 3}})
      @ StaticArraysCore ~/.julia/packages/StaticArraysCore/U2Z1K/src/StaticArraysCore.jl:113
    [5] SArray
      @ ~/.julia/packages/StaticArraysCore/U2Z1K/src/StaticArraysCore.jl:117 [inlined]
    [6] StaticArray
      @ ~/.julia/packages/StaticArrays/a4r2v/src/convert.jl:167 [inlined]
    [7] restructure(x::StaticArraysCore.SVector{30, Float64}, y::StaticArraysCore.SVector{30, ForwardDiff.Dual{ForwardDiff.Tag{typeof(Main.##280.staticf), Float64}, Float64, 3}})
      @ ArrayInterface.ArrayInterfaceStaticArraysCoreExt ~/.julia/packages/ArrayInterface/xqHUD/ext/ArrayInterfaceStaticArraysCoreExt.jl:34
    [8] SparseDiffTools.ForwardColorJacCache(f::typeof(Main.##280.staticf), x::StaticArraysCore.SVector{30, Float64}, _chunksize::Nothing; dx::StaticArraysCore.SVector{30, Float64}, tag::Nothing, colorvec::Vector{Int64}, sparsity::SparseArrays.SparseMatrixCSC{Float64, Int64})
      @ SparseDiffTools ~/work/SparseDiffTools.jl/SparseDiffTools.jl/src/differentiation/compute_jacobian_ad.jl:47

@gaurav-arya
Copy link
Contributor Author

I don't think it's related to ArrayInterface / StaticArrays? There's just a dual number that's trying to be written into a float array cache.

@gaurav-arya
Copy link
Contributor Author

Okay, @vpuri3 you're right that's there some StaticArrays / ArrayInterface shenanigans going on. Various typos also causeed the same error to be thrown at different places in the tests -- those are fixed now.

@gaurav-arya
Copy link
Contributor Author

gaurav-arya commented Mar 28, 2023

@ChrisRackauckas I think this can be merged. CI was previously completely down, so this is a strict improvement, and helps unblock #232. The only thing that fails in CI is test_ad.jl (which I put at the end of runtests.jl so that we can see that everything else now passes) -- that's because of #237.

@ChrisRackauckas
Copy link
Member

Bump the ArrayInterface lower bound to include the patch.

@ChrisRackauckas ChrisRackauckas merged commit 53755d8 into JuliaDiff:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid test group specified in CI
3 participants