Skip to content

Commit

Permalink
deprecate multivariate reconstruct.
Browse files Browse the repository at this point in the history
  • Loading branch information
Datseris committed Nov 14, 2020
1 parent c20d2fa commit 89c0c69
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* `delay_afnn, delay_ifnn, delay_fnn, delay_f1nn` are part of public API now.
* The argument `γs` and the function `reconstruct` is starting to be phased out in
favor of `ds` and `embed`.
* Multi-timeseries via `reconstruct` or `embed` is deprecated in favor of using `genembed`.

## Deprecations
* Using `estimate_dimension` is deprecated in favor of either calling `afnn, fnn, ...` directly or using the function `optimal_traditional_de`
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "DelayEmbeddings"
uuid = "5732040d-69e3-5649-938a-b6b4f237613f"
repo = "https://github.com/JuliaDynamics/DelayEmbeddings.jl.git"
version = "1.12.0"
version = "1.12.1"

[deps]
Distances = "b4f34e82-e78d-54a5-968a-f98e89d6e8f7"
Expand Down
2 changes: 2 additions & 0 deletions src/embeddings.jl
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,8 @@ end

@inline MTDelayEmbedding(γ, τ, B) = MTDelayEmbedding(Val{γ}(), τ, Val{B}())
@inline function MTDelayEmbedding(::Val{γ}, τ::Int, ::Val{B}) where {γ, B}
@warn "Multi-timeseries delay embedding via `reconstruct` is deprecated in favor of "*
"using `genembed` directly."
X = γ*B
idxs = SMatrix{γ,B,Int,X}([k*τ for k in 1:γ, j in 1:B])
return MTDelayEmbedding{γ, B, X}(idxs)
Expand Down

0 comments on commit 89c0c69

Please sign in to comment.