Fix highlighting for macros prefixed by "!" #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes JuliaEditorSupport#201. Checked other regexes for similar issues involving "!" and did not discover any of significance. The Julia manual specifically calls out "!" as being special in this way and no other symbols, so just including "!" as a special-case in regexes is sufficient.
|
@non-Jedi I've invited you to be a member of this organization. Please merge the PR if you think it is good to go. |
|
Thanks. Would like to have at least one other person review before merging. Pinging @tpapp, @giordano, @FelipeLema: could one of you take a quick look? |
FelipeLema
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #201.
Checked other regexes for similar issues involving "!" and did not discover any of significance. The Julia manual specifically calls out "!" as being special in this way and no other symbols, so just including "!" as a special-case in regexes is sufficient.
Test failure on emacs 29 is unrelated and due to #199.