Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip whitespace in latexsub :exit-function #206

Closed
wants to merge 2 commits into from
Closed

Strip whitespace in latexsub :exit-function #206

wants to merge 2 commits into from

Commits on Mar 15, 2024

  1. Strip whitespace in latexsub :exit-function 

    According to the docstring for completion-extra-properties, the "STRING" passed to the
:exit-function should be the bare text to which the field was completed, but helm-mode adds
an extra space at the end of "STRING". Since none of our latexsubs include whitespace, we
can safely strip whitespace in the :exit-function and work around this helm bug.

I will file an upstring bug report against helm, but I think it's worth fixing quickly here
since it's only a simple 3-line change.

Closes #204.
    @non-Jedi
    non-Jedi committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    20a95d6 View commit details
    Browse the repository at this point in the history

  2. Use string-trim-right instead of string-clean-whitespace 

    string-clean-whitespace does more than is needed and is provided by subr-x instead of just
subr, so was causing tests to fail on older emacs versions.
    @non-Jedi
    non-Jedi committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    696dcd8 View commit details
    Browse the repository at this point in the history