Skip to content
This repository was archived by the owner on Sep 4, 2024. It is now read-only.

adding RLC load model #60

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

adding RLC load model #60

wants to merge 4 commits into from

Conversation

SabineAuer
Copy link
Member

No description provided.

@SabineAuer SabineAuer added enhancement New feature or request DO NOT MERGE do not merge this PR as it is not finished labels Mar 26, 2019
@SabineAuer SabineAuer self-assigned this Mar 26, 2019
@SabineAuer SabineAuer requested a review from timziebart March 26, 2019 11:19
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #60 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #60      +/-   ##
=========================================
+ Coverage   89.32%   89.5%   +0.17%     
=========================================
  Files          21      22       +1     
  Lines         356     362       +6     
=========================================
+ Hits          318     324       +6     
  Misses         38      38
Impacted Files Coverage Δ
src/PowerDynBase.jl 100% <ø> (ø) ⬆️
src/NodeDynamics/RLC-Load.jl 100% <100%> (ø)
src/DynamicNodeMacro.jl 94.8% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d4eeb...ddcb1b0. Read the comment docs.

@timziebart
Copy link
Member

timziebart commented Mar 26, 2019

You asked for a review but there is still the "do not merge" badge?

What do you want me to do? (:

@SabineAuer
Copy link
Member Author

SabineAuer commented Mar 26, 2019

I created the pull request but I need the review not now since it's still work in progress. That is why "do not merge". :)

@timziebart
Copy link
Member

OK, I will dismiss the review request (when I am on laptop) and you can request the review when you are actually done.

@SabineAuer SabineAuer removed the request for review from timziebart March 26, 2019 16:30
Copy link
Member

@timziebart timziebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please finish and then request the review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO NOT MERGE do not merge this PR as it is not finished enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants