Adding crypto as subpackage #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @roshii I'll try to help out. I've been distracted, but don't want to slow you down. You've got some good momentum going. I need to think about this a little more though 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As quickly discussed on JuliaFinance Roadmap, please see my code proposal for adding Crypto as a sub package of
Currencies.jlThere is a lot of duplication still, and I'm sure this draft code can be greatly improved.
The Crypto csv file is quite limited as well and will grow as needs arises. I was also thinking at adding extra columns with crypto constants such as supply limit...