Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export config to disk. #10

Closed
codetalker7 opened this issue Jul 12, 2024 · 1 comment · Fixed by #27
Closed

Export config to disk. #10

codetalker7 opened this issue Jul 12, 2024 · 1 comment · Fixed by #27
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@codetalker7
Copy link
Member

Ideally the config used for indexing should be saved to disk as part of the indexing plan, possibly in json. See _save_plan for reference.
@codetalker7 codetalker7 added enhancement New feature or request good first issue Good for newcomers labels Jul 12, 2024
@codetalker7 codetalker7 linked a pull request Aug 16, 2024 that will close this issue
Many design changes + optimizations. #27
Merged
@codetalker7
Copy link
Member Author

This was completed in #27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Many design changes + optimizations. JuliaGenAI/ColBERT.jl
1 participant
@codetalker7