Many design changes + optimizations. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambiguitities.
updating the examples.
they aren't really needed.
`tensorize` to `tensorize_docs`. Also moving util functions to `utils.jl`.
better interface.
`tensorize_queries`.
types and the most important types for ColBERT (i.e `Checkpoint` and `ColBERTConfig`). This makes testing easier.
will help in testing.
primitive types.
codetalker7
changed the title
friendly; moving file saving and loading to a higher level `index` function.
Closed
Closed
|
Closes #9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to mainly add a lot of small design changes, plus a few more optimizations. I try to get rid of all the types which aren't really required; this philosophy is to keep minimal types, and to delegate everything else to methods. This will also make testing easier.