flesh out GI for tables and rows #136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| GeoInterface.crs(::GeoInterface.FeatureCollectionTrait, t::Table) = GeoInterface.crs(getshp(t)) | ||
|
|
||
| GeoInterface.trait(::Table) = GeoInterface.FeatureCollectionTrait() | ||
| GeoInterface.getfeature(t::Table) = t |
There was a problem hiding this comment.
I added a line for this to the tests. Of course it's a trivial implementation but don't we still need it?
There was a problem hiding this comment.
I would rather leave that to the default iterator, because you call GI.getfeature on this and it returns exactly the same thing, which is pretty confusing IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @tiemvanderdeure
This still needs more fixes for GeometryOps compat which I will add as time permits. But in general at least it helps.