Refactor and add a TigerLine.get function that can do everything
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the Format.jl dependency and makes life simpler
|
@asinghvi17 , been tinkering a bit further with this and have one thought: I find the use of Scratch.jl clever but too clever. I wouldn't expect one of my mentees or students to know where to look to find their data after running |
|
Hmm, I wouldn't expect them to use the file path at all - the idea of get is that you set it and forget it, in some sense, and it caches the download for you. If you want the file path you could always use download_tiger was my initial thought... |
|
That's fair @asinghvi17 -- I'll keep tinkering to show you how I am imagining things being used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the Format.jl dependency and makes life simpler for the end user, all they need to do is
and it gives them a Shapefile.jl table that is ready for analysis.
This also factors the code that gets the list of files available under that heading out of the download function into a new function that is common.
getuses Scratch.jl to cache files so you don't have to keep re-downloading. This assumes that the source data is not going to change, which seems reasonable to me.