-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing tests #74
Conversation
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
===========================================
+ Coverage 58.94% 97.12% +38.18%
===========================================
Files 3 3
Lines 397 383 -14
===========================================
+ Hits 234 372 +138
+ Misses 163 11 -152
Continue to review full report at Codecov.
|
This is ready for review now. A few notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most seem to be fine. I've added suggestions for adding more tests and minor updates.
Co-authored-by: Yuto Horikawa <[email protected]>
Thanks for the very thorough review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a very minor suggestion.
Co-authored-by: Yuto Horikawa <[email protected]>
The goal of this PR is to get (close to) complete coverage by adding missing tests. for already-implemented functionality.