Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tests #74

Merged
merged 64 commits into from
Mar 7, 2022
Merged

Add missing tests #74

merged 64 commits into from
Mar 7, 2022

Conversation

sethaxen
Copy link
Collaborator

The goal of this PR is to get (close to) complete coverage by adding missing tests. for already-implemented functionality.

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #74 (a779f44) into master (247d149) will increase coverage by 38.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #74       +/-   ##
===========================================
+ Coverage   58.94%   97.12%   +38.18%     
===========================================
  Files           3        3               
  Lines         397      383       -14     
===========================================
+ Hits          234      372      +138     
+ Misses        163       11      -152     
Impacted Files Coverage Δ
src/DualQuaternion.jl 95.23% <100.00%> (+73.45%) ⬆️
src/Octonion.jl 96.15% <100.00%> (+68.10%) ⬆️
src/Quaternion.jl 98.50% <100.00%> (+10.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 247d149...a779f44. Read the comment docs.

@sethaxen sethaxen marked this pull request as ready for review March 5, 2022 19:02
@sethaxen sethaxen requested a review from hyrodium March 5, 2022 19:04
@sethaxen
Copy link
Collaborator Author

sethaxen commented Mar 5, 2022

This is ready for review now. A few notes:

  • It replaces convert methods with more constructors, which allows us to use the default convert methods in base.
  • It deletes code for branches that are unreachable by the tests
  • A number of tests are broken; these indicate bugs that should be fixed in future PRs.
  • All lines should be covered now except for the show methods, which are never used and do not overload Base.show

Copy link
Collaborator

@hyrodium hyrodium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most seem to be fine. I've added suggestions for adding more tests and minor updates.

test/DualQuaternion.jl Outdated Show resolved Hide resolved
test/DualQuaternion.jl Outdated Show resolved Hide resolved
test/DualQuaternion.jl Show resolved Hide resolved
test/DualQuaternion.jl Outdated Show resolved Hide resolved
test/DualQuaternion.jl Outdated Show resolved Hide resolved
test/Octonion.jl Show resolved Hide resolved
test/Octonion.jl Outdated Show resolved Hide resolved
test/Quaternion.jl Outdated Show resolved Hide resolved
test/Quaternion.jl Show resolved Hide resolved
test/Quaternion.jl Show resolved Hide resolved
@sethaxen
Copy link
Collaborator Author

sethaxen commented Mar 6, 2022

Thanks for the very thorough review!

Copy link
Collaborator

@hyrodium hyrodium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a very minor suggestion.

test/DualQuaternion.jl Outdated Show resolved Hide resolved
@sethaxen sethaxen merged commit ffe1bf8 into JuliaGeometry:master Mar 7, 2022
@sethaxen sethaxen deleted the moretests branch March 7, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants