add Slerp for 3D rotations #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 88.82% 88.84% +0.02%
==========================================
Files 16 16
Lines 1602 1605 +3
==========================================
+ Hits 1423 1426 +3
Misses 179 179
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hyrodium
reviewed
Feb 28, 2023
Co-authored-by: Yuto Horikawa <[email protected]>
Co-authored-by: Yuto Horikawa <[email protected]>
|
Thank you for reviewing. I've update the PR following your advice. Can you look at the changes and give me feedback again? |
|
Thank you! |
|
I haven't been active here lately, but I thought I'd pop in and say thanks @hyrodium for doing a great job maintaining this package. It's amazing to have people like you step in and care for code I once worked on, but don't have time for right now. Thanks ❤️ (Also thanks @bicycle1885 for the specific contribution here, this looks nice :-) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
slerpfor 3D rotations. The method forQuatRotations is the canonical implementation and methods for other rotation types are implemented via this canonical one.I don't know which representation it should return for arguments with mixed types. The proposed one returns
typeof(r1)forslerp(r1, r2, t).Closes #214.