Replace _print with lower
#173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In JSON v0.7.0 and beyond, overloads of `_print` are deprecated in favour of overloading the simpler `lower` function.
4 tasks
TotalVerb
changed the title
_print with lower_print with lower
|
Should be good to merge now. |
|
Oops, I didn't mean to close. |
|
This is failing on the overnight/v0.6, but passes for 0.5. Do we merge this, then fix the 0.6 issues down the line? Or, @TotalVerb can you figure out what will make this pass for 0.6? |
|
@randyzwitch Thanks for bringing that to my attention. I'll test on v0.6 and figure out what's causing the issues. |
|
@randyzwitch I think the problem is independent of this PR. I believe I've found the issue and will submit an unrelated PR addressing it. |
|
@randyzwitch Although I suspected that I found the issue, I don't think I am able to address it. Perhaps it is also a local issue on my configuration only. See #176. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JSON v0.7.0 and beyond, overloads of
_printare deprecated in favour of overloading the simplerlowerfunction.The new JSON tag is not yet merged; see JuliaLang/METADATA.jl#5988. I'll ping you when it is.