Update dialog JavaScript for newer Electron API #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differences in the security model of later versions of Electron meant that a few tweaks were necessary to ensure compatibility with the latest updates to Blink.jl
mosullivan93
force-pushed
the
electron-update
branch
from
9c4f82e to
3e755dd
Compare
|
Converting to draft. This PR depends on the changes in Blink#309. |
|
This would be very useful for solving a bug in our user interface in the Koma.jl package. Is there any news on this @mosullivan93? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the open/save dialog functionality for the latest version of the Blink package. Even after fixing the undefined variables, differences in the security model of newer versions of Electron meant that a few tweaks were necessary to ensure compatibility.
This patch is co-dependent on an update to
Blink.jl, as well. Merging PR JuliaGizmos/Blink.jl#309 and updating the compatibility constraints forProject.tomlmay be necessary to prevent the potential for users to end up with a broken project.This patch supplements the resolution to JuliaGizmos/Interact.jl#414 (in piever/InteractBase.jl#176) to fix an additional complication arising from the updated Electron in
Blink.jl.