Skip to content

Handle transitive dependencies with Julia master #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle transitive dependencies with Julia master #372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ec8e39
Handle transitive dependencies with Julia master
eschnett Sep 15, 2025
87bb381
Simplify code
eschnett Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Cairo.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,16 @@ import Graphics: arc, clip, clip_preserve, close_path, creategc, device_to_user!
import Base: copy, fill

libcairo_version = VersionNumber(unsafe_string(
ccall((:cairo_version_string,Cairo.libcairo),Cstring,()) ))
ccall((:cairo_version_string,libcairo),Cstring,()) ))
libpango_version = VersionNumber(unsafe_string(
ccall((:pango_version_string,Cairo.libpango),Cstring,()) ))
ccall((:pango_version_string,Pango_jll.libpango),Cstring,()) ))
if !Sys.iswindows()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try removing this? My hunch is that this was necessary because the wrong library was being referenced.

libpangocairo_version = VersionNumber(unsafe_string(
ccall((:pango_version_string,Cairo.libpangocairo),Cstring,()) ))
ccall((:pango_version_string,Pango_jll.libpango),Cstring,()) ))
libgobject_version = VersionNumber(
unsafe_load(cglobal((:glib_major_version, Cairo.libgobject), Cuint)),
unsafe_load(cglobal((:glib_minor_version, Cairo.libgobject), Cuint)),
unsafe_load(cglobal((:glib_micro_version, Cairo.libgobject), Cuint)))
unsafe_load(cglobal((:glib_major_version, Glib_jll.libglib), Cuint)),
unsafe_load(cglobal((:glib_minor_version, Glib_jll.libglib), Cuint)),
unsafe_load(cglobal((:glib_micro_version, Glib_jll.libglib), Cuint)))
Comment on lines -31 to +35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I think this was right.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And would probably work on Windows, too.

end

import Base.show
Expand Down
Loading