Update to edge and nodestroke linewidths. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the checks failed when attempting to build the Homebrew package. I'm not sure why this has happened and haven't touched this before. When someone has time could they help clear this up for me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that that the
edgelinewidthandnodestrokelwdidn't play very nicely together. I added aLINEWIDTHparameter to replaceEDGELINEWIDTH, which is used for both of the previous parameters.edgelinewidthandnodestrokelwshould function properly if used independently and together. When using arrays as inputs, each will be scaled relative to their maximum in each array.I have attached a jupyter notebook with some examples of the change.
graphplot_linewidth.ipynb.tar.gz
note: this is actually my first time creating a pull request, so apologies if I've made some kind of breach of etiquette.