Skip to content

Time Comparison (Attempt 2)#467

Closed
rkierulf wants to merge 3 commits intomasterfrom
time-comparison-4
Closed

Time Comparison (Attempt 2)#467
rkierulf wants to merge 3 commits intomasterfrom
time-comparison-4

Conversation

@rkierulf
Copy link
Copy Markdown
Collaborator

2nd attempt at reverting to the commit adding the benchmarking CI for a time comparison. I think it should work this time since I used this solution here: https://stackoverflow.com/questions/32841671/reverting-to-a-specific-commit-without-losing-history which shouldn't rewrite history like git reset.

@rkierulf rkierulf requested a review from cncastillo as a code owner August 20, 2024 18:28
@cncastillo
Copy link
Copy Markdown
Member

The pull-requests: write may be necessary for the benchmarking report, but let's see!

@cncastillo cncastillo changed the title Time Comparison (Attempt #2) Time Comparison (Attempt 2) Aug 20, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.45%. Comparing base (57f8698) to head (0ffeac9).

Files Patch % Lines
KomaMRIBase/src/datatypes/sequence/RF.jl 60.00% 6 Missing ⚠️
KomaMRIBase/src/datatypes/sequence/Grad.jl 87.50% 2 Missing ⚠️
KomaMRIBase/src/timing/TrapezoidalIntegration.jl 50.00% 1 Missing ⚠️
KomaMRICore/ext/KomaoneAPIExt.jl 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
- Coverage   90.75%   90.45%   -0.31%     
==========================================
  Files          53       51       -2     
  Lines        2932     2796     -136     
==========================================
- Hits         2661     2529     -132     
+ Misses        271      267       -4     
Flag Coverage Δ
base 88.02% <85.24%> (-0.18%) ⬇️
core 90.37% <96.87%> (-1.29%) ⬇️
files 93.55% <100.00%> (ø)
komamri 93.98% <100.00%> (ø)
plots 89.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
KomaMRIBase/src/KomaMRIBase.jl 100.00% <ø> (ø)
KomaMRIBase/src/datatypes/Phantom.jl 85.10% <ø> (ø)
KomaMRIBase/src/datatypes/Sequence.jl 92.60% <100.00%> (+0.13%) ⬆️
KomaMRIBase/src/datatypes/sequence/ADC.jl 94.59% <100.00%> (ø)
KomaMRIBase/src/sequences/PulseDesigner.jl 94.05% <100.00%> (-0.18%) ⬇️
KomaMRICore/ext/KomaAMDGPUExt.jl 80.00% <ø> (+7.27%) ⬆️
KomaMRICore/ext/KomaCUDAExt.jl 88.88% <ø> (+8.88%) ⬆️
KomaMRICore/src/KomaMRICore.jl 100.00% <100.00%> (ø)
KomaMRICore/src/datatypes/Spinor.jl 93.75% <ø> (+5.51%) ⬆️
KomaMRICore/src/rawdata/ISMRMRD.jl 98.36% <100.00%> (+1.63%) ⬆️
... and 16 more

... and 1 file with indirect coverage changes

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KomaMRI Benchmarks

Details
Benchmark suite Current: 0ffeac9 Previous: 57f8698 Ratio
MRI Lab/Bloch/CPU/2 thread(s) 1359257608 ns 226618506 ns 6.00
MRI Lab/Bloch/CPU/4 thread(s) 910612378.5 ns 174536994 ns 5.22
MRI Lab/Bloch/CPU/8 thread(s) 822300057 ns 146360095.5 ns 5.62
MRI Lab/Bloch/CPU/1 thread(s) 3306709700 ns 347644824 ns 9.51
MRI Lab/Bloch/GPU/CUDA 151919104 ns 57253633 ns 2.65
MRI Lab/Bloch/GPU/oneAPI 27115286387 ns 515042255.5 ns 52.65
MRI Lab/Bloch/GPU/Metal 3247290708 ns 541353541 ns 6.00
MRI Lab/Bloch/GPU/AMDGPU 115785398 ns 37619574.5 ns 3.08
Slice Selection 3D/Bloch/CPU/2 thread(s) 2543793149 ns 1024148878 ns 2.48
Slice Selection 3D/Bloch/CPU/4 thread(s) 1686269181 ns 580936747 ns 2.90
Slice Selection 3D/Bloch/CPU/8 thread(s) 1175244816 ns 386777586 ns 3.04
Slice Selection 3D/Bloch/CPU/1 thread(s) 5900630273.5 ns 1925568005.5 ns 3.06
Slice Selection 3D/Bloch/GPU/CUDA 269806857.5 ns 100754922 ns 2.68
Slice Selection 3D/Bloch/GPU/oneAPI 2167922297 ns 654922437.5 ns 3.31
Slice Selection 3D/Bloch/GPU/Metal 1413343333 ns 564653500 ns 2.50
Slice Selection 3D/Bloch/GPU/AMDGPU 96626718.5 ns 60779232 ns 1.59

This comment was automatically generated by workflow using github-action-benchmark.

@rkierulf rkierulf closed this Aug 20, 2024
@cncastillo cncastillo deleted the time-comparison-4 branch August 21, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants