Update to FFMPEG 8.0.0 #433
Open
+2,222
−3,182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FFMPEG_jll update JuliaPackaging/Yggdrasil#12390 |
IanButterworth
force-pushed
the
ffmpeg8
branch
from
2304b0b to
19abf71
Compare
IanButterworth
force-pushed
the
ffmpeg8
branch
from
749a13c to
0431628
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #433 +/- ##
==========================================
- Coverage 78.29% 77.60% -0.69%
==========================================
Files 10 10
Lines 1313 1313
==========================================
- Hits 1028 1019 -9
- Misses 285 294 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@yuyichao this is looking good to me. I'll merge and release in a day or so, unless you see anything else that needs doing? |
|
Just in case anything here strikes you as needing fixing, JET finds some issues in libffmpeg on this branch (similar on master) |
IanButterworth
force-pushed
the
ffmpeg8
branch
from
00c922d to
bf49de7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated using an external installation of ffmpeg.
I did need to do a manual edit since the definition for
AVVkFrameInternalwas generated after it's first use. I assume this is because the header did not forward declareAVVkFrameInternalbefore using it asstruct AVVkFrameInternal *internalinAVVkFrame. This is perfectly legal C and maybe clang.jl generator doesn't handle this too well...Passes all the tests with #432