Split errors into AllocationSite, AllocatingRuntimeCall, and DynamicDispatch
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
force-pushed
the
ct/refactor
branch
from
d89054a to
690ede9
Compare
|
Should we call them errors or something else? And maybe we should add an option to the macro so it executes anyway? But prints this as a warning? |
Open to suggestions 🙂
I'd be open to a |
|
I guess errors are fine. They look like errors, so I guess that sets the expectation |
…amicDispatch` This makes it much easier to understand the three main enemies one will have when trying to eliminate allocations. This also does a major re-factoring of the `allocfunc.jl` internals while we're at it.
Try and look through the global to see it's initializer
This needs to be expanded still, but it's much better than nothing. This also bundles up various tweaks to the first commit in this PR.
Still needs a bit of refinement/DRY, but this is enough to get things working.
Apparently terminal support for this is quite poor, so perhaps we should avoid it all together?
topolarity
force-pushed
the
ct/refactor
branch
from
cf5f78f to
644bb5f
Compare
Closed
Closed
|
Time to go public 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it much easier to understand the three main opponents one will have when trying to eliminate allocations.
This also does a major re-factoring of the
allocfunc.jlinternals while we're at it.Example:
