avoid returning empty completion when aborting to not have it inline directories #3917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…complete directories
|
I believe I still lack the composure to review this PR. As a matter of fact, my REPL did not hint "Documents/" when "Doc" was typed, and hinted "DocumenterTools" when "DocumenterT" was typed. |
|
This is definitely an improvement, but I realized that this is not a perfect solution after looking at JuliaLang/julia#54906 (unrelated to this PR). If you type "add Cha", "ChainRules" and "ChainRulesCore" will be candidates, and "ChainRules" will be displayed as a hint. Given the existence of "Chairmarks", the hint is somewhat misleading. |
|
I didn't know that the inline auto complete did partial completions like that. I even thought I tried it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #3916 (haven't tested)