-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add lts field #41
base: main
Are you sure you want to change the base?
add lts field #41
Conversation
Looks good. I was expecting only the latest patch to be marked as lts but I guess this makes sense. |
Indeed, I did debate that before deciding on the current behaviour. Every patch release for a given version does on its own count as an lts release. I find it also fits the current behaviour with the stable field, since one needs to find the most recent stable release by filtering all version tags with |
Seems a little odd to mark every single patch with the What happens when a new LTS is chosen? Do the old LTS versions keep the |
It seems correct to me. The patch releases are all part of the LTS release minor version. |
That is a good point. I can follow up with another pr that can maybe take advantage of YAML multi-line strings so that multiple lts releases can be added. Will need to try this out myself first. I agree that it does look odd in the release feed. This could probably be improved upon with a new version of the JSON schema along with other improvements (potential GSoC proposal :) ). |
Hold that thought, actually. I might be able to implement it here instead, especially because I don't want to accidentally skip the last lts release (1.6). |
Turns out I was overthinking this. We can simply list all the lts releases in |
Add an "lts" field to each tag in the JSON release feed. This is set via the JULIA_LTS variable in the CI workflow, which only requires that the major and minor version numbers match (no need to manually set for every patch release). Tested locally with LocalStack.
This is a follow-up attempt from #32 which broke the Buildkite plugin. It was thereafter decided to simply include lts tagging as a new field for each release tag, rather than it be its own tag. It will be up to downstream consumers to select the most recent lts release, since every patch release for the given version will possess
"lts": true
.Closes #2
@IanButterworth @DilumAluthge