use === for String, String equality. (#27790)

* use === for String, String equality * do pointer equality check before memory check * remove whitespace * Update base/strings/string.jl Co-Authored-By: oxinabox <[email protected]> * Update base/strings/string.jl Co-Authored-By: oxinabox <[email protected]>
JuliaLang · Jan 18, 2019 · eb18db5 · eb18db5 · nanosoldier · Jan 19, 2019
1 parent 30c6ee7
commit eb18db5
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/base/strings/string.jl b/base/strings/string.jl
@@ -100,8 +100,9 @@ function cmp(a::String, b::String)
 end
 
 function ==(a::String, b::String)
+    pointer_from_objref(a) == pointer_from_objref(b) && return true
     al = sizeof(a)
-    al == sizeof(b) && 0 == ccall(:memcmp, Int32, (Ptr{UInt8}, Ptr{UInt8}, UInt), a, b, al)
+    return al == sizeof(b) && 0 == ccall(:memcmp, Int32, (Ptr{UInt8}, Ptr{UInt8}, UInt), a, b, al)
 end
 
 typemin(::Type{String}) = ""