Skip to content

Commit

Permalink
Fix string handling in jlchecksum (#56720)
Browse files Browse the repository at this point in the history
A `TAGGED_RELEASE_BANNER` with spaces such as `Official
https://julialang.org release` produces the error
`/cache/build/builder-amdci4-5/julialang/julia-master/deps/tools/jlchecksum:
66: [: Official: unexpected operator`.
  • Loading branch information
Zentrik authored Dec 1, 2024
1 parent d32843b commit ef32806
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deps/tools/jlchecksum
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ find_checksum()
fi
done
if [ ! -f "$DEPSDIR/checksums/$BASENAME/$CHECKSUM_TYPE" ]; then
if [ ${TAGGED_RELEASE_BANNER:-} ]; then
if [ "${TAGGED_RELEASE_BANNER:-}" ]; then
echo "WARNING: $CHECKSUM_TYPE checksum for $BASENAME not found in deps/checksums/, failing release build." >&2
exit 3
fi
Expand Down

2 comments on commit ef32806

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Please sign in to comment.