Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error when collecting from iterators with inconsistent length #29458

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Throw an error when collecting from iterators with inconsistent length #29458

wants to merge 3 commits into from

Commits on Oct 1, 2018

  1. Throw an error when collecting from iterators with inconsistent length 

    Check that HasLength and HasShape iterators return the same number of elements
as indicated by length(itr). An error was already thrown in some situations when
the number of elements was higher than the declared length, but not all.
    @nalimilan
    nalimilan committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    3f4a404 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2018

  1. Review fixes

    @nalimilan
    nalimilan committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    e811fa6 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2018

  1. Use _copy_impl! instead of custom function

    @nalimilan
    nalimilan committed Oct 6, 2018
    Configuration menu
    Copy the full SHA
    c7b6896 View commit details
    Browse the repository at this point in the history