Add edges vector to CodeInstance/CodeInfo to keep backedges as edges
#54894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/codeinfo-edges
branch
from
af946a0
to
0277c82
Compare
vtjnash
force-pushed
the
jn/codeinfo-edges
branch
from
0277c82
to
af03fd5
Compare
This records all invoke targets as edges as a functionality test, before finishing the implementation of recording the edges accurately during inference (via backedges + inference).
vtjnash
force-pushed
the
jn/codeinfo-edges
branch
from
af03fd5
to
91be20b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appears to add about 1MB to the system image, but to decrease the stdlib size by 2MB, so seems overall favorable. The edges are not being computed yet (following the encoding https://hackmd.io/sjPig55kS4a5XNWC6HmKSg?both#Edges-Encoding) to correctly reflect the backedges, but they currently are just extracting the
:invokefields.