Fix accidental early evaluation of imported using
binding
#54956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
using A.B
, we need to evaluateA.B
to add the module to the using list. However, inusing A: B
, we do not care about the value ofA.B
, we only operate at the binding level. These two operations share a code path and the evaluation ofA.B
happens early and is unused on theusing A: B
path. I believe this was an unintentional oversight when the latter syntax was added. Fixes #54954.