Document how return types and return values should be used in docstrign signature lines #57583
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gn signature lines
nsajko
reviewed
Feb 28, 2025
|
Perhaps also add to the style guide in the manual? |
nsajko
reviewed
Feb 28, 2025
Yep! That's #57580 |
Co-authored-by: Neven Sajko <[email protected]>
Co-authored-by: Neven Sajko <[email protected]>
|
thumbs down because #57012 (comment) (sorry i didn't see this discussion til this PR, so understand this might have been decided, but i do think it could have an unintended consequence if it spreads an anti-pattern in code itself) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the first step in #57012 (comment). See the discussion there for more info. Once this merges, #57012 will implement the recommended method throughout base and in-tree stdlibs.