WIP: Turn Expr(:method) into a builtin
#60099
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continues the recent work to turn special lowered-IR forms into builtins when those forms do not have any syntactic impact. Written by Claude. Will hold until #59870 merges and then make the analogous changes there.
vtjnash
reviewed
Nov 11, 2025
| e.head = deserialize(s)::Symbol | ||
| e.args = Any[ deserialize(s) for i = 1:len ] | ||
|
|
||
| # Rewrite old :method expressions to define_method calls |
Member
There was a problem hiding this comment.
Seems unlikely we should encounter or support this, since pre-lowered top level code is a pretty buggy concept even in a single session
Member
Author
There was a problem hiding this comment.
We have a specific test for this case, so I added the compat. We can remove the test if course
Member
There was a problem hiding this comment.
Weird, but I guess harmless probably
| mt = (jl_methtable_t*)fname; | ||
| jl_value_t *atypes = args[2]; | ||
| jl_value_t *meth = args[3]; | ||
| jl_method_t *ret = jl_method_def((jl_svec_t*)atypes, mt, (jl_code_info_t*)meth, module); |
Member
There was a problem hiding this comment.
Does this need a check that the module is "open" or does it already have that internally?
Member
Author
There was a problem hiding this comment.
I'll double check, but you may be correct that we were relying on the eval check before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the recent work to turn special lowered-IR forms into builtins when those forms do not have any syntactic impact. Written by Claude. Will hold until #59870 merges and then make the analogous changes there.