Don't show julia update messages when not interactive
#1258
+189
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clippy failures addressed in #1259 |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to suppress Julia update messages when running in non-interactive mode, addressing issue #1256. The change prevents update notifications from appearing when Julia is run with command-line arguments like --version or -e.
- Added test infrastructure methods for accessing config paths and depot directories
- Implemented comprehensive tests to verify update message suppression in non-interactive scenarios
- Added test coverage for both single channel and multi-channel update scenarios
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/utils.rs | Added helper methods to access config file path and depot directory path |
| tests/command_update.rs | Added comprehensive tests verifying update messages don't appear in non-interactive Julia usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
I think the src changes are simple enough here. Review still welcome but I'm going to proceed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1256
@KristofferC