fix link to SnoopCompile docs #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
reviewed
Oct 5, 2024
| @@ -330,7 +330,7 @@ It's worth noting that the task of improving code is never finished, and this is | |||
| ## Tools for analyzing and fixing invalidations | |||
|
|
|||
| Recently, the [SnoopCompile] package gained the ability to analyze invalidations and help developers fix them. | |||
| Because these tools will likely change over time, this blog post will only scratch the surface; people who want to help fix invalidations are encouraged to read [SnoopCompile's documentation](https://timholy.github.io/SnoopCompile.jl/stable/snoopr/) for further detail. | |||
| Because these tools will likely change over time, this blog post will only scratch the surface; people who want to help fix invalidations are encouraged to read [SnoopCompile's documentation](https://timholy.github.io/SnoopCompile.jl/dev/) for further detail. | |||
There was a problem hiding this comment.
Seems like it would be better to link to the stable docs instead of the dev docs, right?
The following URL seems to work:
Suggested change
| Because these tools will likely change over time, this blog post will only scratch the surface; people who want to help fix invalidations are encouraged to read [SnoopCompile's documentation](https://timholy.github.io/SnoopCompile.jl/dev/) for further detail. | |
| Because these tools will likely change over time, this blog post will only scratch the surface; people who want to help fix invalidations are encouraged to read [SnoopCompile's documentation](https://timholy.github.io/SnoopCompile.jl/stable/) for further detail. |
There was a problem hiding this comment.
the main page doesn't link to stable docs, which made me think Tim wants people to go to dev docs: https://github.com/timholy/SnoopCompile.jl
There was a problem hiding this comment.
Hmmm, interesting.
@timholy Which one (stable or dev) should we link to on the Julia website?
There was a problem hiding this comment.
I'll merge this to fix the 404. Necessary changes can follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prior link 404s