Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #56

Merged
merged 2 commits into from
Jun 24, 2023
Merged

fix typos #56

merged 2 commits into from
Jun 24, 2023

Conversation

spaette
Copy link
Contributor

@spaette spaette commented Jun 23, 2023

README.md
ext/DensityRatioEstimationGPUArraysExt.jl
src/kmm/jump.jl
src/utils.jl
test/runtests.jl

marking this a draft

this might be more clear - aside from fixing the typo hebaves - if it were as follows

It behaves differently based on whether mat is on a CPU or GPU.

$ ed -s DensityRatioEstimation.jl/src/utils.jl <<<'52,62p'
"""
    safe_diagm(mat, a)

Generate a squared matrix whose diagonal is `a` that is 
compatible to perform addition on `mat`. It hebaves 
differently based on `mat` is on CPU or GPU.

It is compatible with
- CuArrays.jl (see lib/cuarrays.jl)
- Zygote.jl (see lib/zygote.jl)
"""
$ 

@spaette spaette marked this pull request as draft June 23, 2023 22:55
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Merging #56 (0c30612) into master (647a20e) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   68.22%   68.22%           
=======================================
  Files          18       18           
  Lines         214      214           
=======================================
  Hits          146      146           
  Misses         68       68           
Impacted Files Coverage Δ
ext/DensityRatioEstimationGPUArraysExt.jl 0.00% <ø> (ø)
src/kmm/jump.jl 100.00% <ø> (ø)
src/utils.jl 75.00% <ø> (ø)

@spaette
Copy link
Contributor Author

spaette commented Jun 24, 2023

@juliohm

Have you an opinion on a possible rewording of the reproduced extract from src/utils.jl?

@juliohm
Copy link
Member

juliohm commented Jun 24, 2023

The suggestion is great @spaette , feel free to improve the text.

Also, maybe you could consider writing a GitHub Action that looks into Julia repositories and corrects misspellings. For example, take a look at TagBot Julia, JuliaFormater.jl and similar projects that define these GitHub Actions.

That way people can always run this robot automatically on every commit that is merged into the master branch.

@spaette spaette marked this pull request as ready for review June 24, 2023 17:25
@juliohm juliohm merged commit 5305648 into JuliaML:master Jun 24, 2023
6 checks passed
@spaette
Copy link
Contributor Author

spaette commented Jun 24, 2023

consider writing a GitHub Action

I'm not very active in the JuliaLang programming community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants