Skip to content

Commit

Permalink
Don't export the fused variants.
Browse files Browse the repository at this point in the history
  • Loading branch information
kellertuer committed Feb 1, 2025
1 parent f1e121c commit acda8b7
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 17 deletions.
14 changes: 7 additions & 7 deletions ext/ManifoldsTestExt/tests_general.jl
Original file line number Diff line number Diff line change
Expand Up @@ -209,22 +209,22 @@ function test_manifold(
Test.@test isapprox(
M,
pts[1],
exp_fused(M, pts[1], X1, 0);
Manifolds.exp_fused(M, pts[1], X1, 0);
atol=atolp1p2,
rtol=rtolp1p2,
)
Test.@test isapprox(
M,
pts[2],
exp_fused(M, pts[1], X1, 1);
Manifolds.exp_fused(M, pts[1], X1, 1);
atol=atolp1p2,
rtol=rtolp1p2,
)
if is_mutating
q2 = allocate(pts[1])
exp!(M, q2, pts[1], X1)
Test.@test isapprox(M, pts[2], q2; atol=atolp1p2, rtol=rtolp1p2)
exp_fused!(M, q2, pts[1], X1, 0)
Manifolds.exp_fused!(M, q2, pts[1], X1, 0)
Test.@test isapprox(M, pts[1], q2; atol=atolp1p2, rtol=rtolp1p2)
end
if VERSION >= v"1.5" && isa(M, Union{Grassmann,GeneralizedStiefel})
Expand All @@ -244,7 +244,7 @@ function test_manifold(
Test.@test isapprox(
M,
pts[1],
exp_fused(M, pts[1], X1, 0);
Manifolds.exp_fused(M, pts[1], X1, 0);
atol=atolp1p2,
rtol=rtolp1p2,
)
Expand Down Expand Up @@ -282,8 +282,8 @@ function test_manifold(
X1 = log(M, pts[1], pts[2])
end

Test.@test isapprox(M, exp_fused(M, pts[1], X1, 1), pts[2]; atol=atolp1)
Test.@test isapprox(M, exp_fused(M, pts[1], X1, 0), pts[1]; atol=atolp1)
Test.@test isapprox(M, Manifolds.exp_fused(M, pts[1], X1, 1), pts[2]; atol=atolp1)
Test.@test isapprox(M, Manifolds.exp_fused(M, pts[1], X1, 0), pts[1]; atol=atolp1)

if test_norm
Test.@test distance(M, pts[1], pts[2]) norm(M, pts[1], X1)
Expand Down Expand Up @@ -328,7 +328,7 @@ function test_manifold(
Test.@test isapprox(
M,
p,
retract_fused(M, p, X, 0, retr_method);
Manifolds.retract_fused(M, p, X, 0, retr_method);
atol=epsx * retraction_atol_multiplier,
rtol=retraction_atol_multiplier == 0 ?
sqrt(epsx) * retraction_rtol_multiplier : 0,
Expand Down
4 changes: 0 additions & 4 deletions src/Manifolds.jl
Original file line number Diff line number Diff line change
Expand Up @@ -839,8 +839,6 @@ export ×,
embed!,
exp,
exp!,
exp_fused,
exp_fused!,
flat,
flat!,
gaussian_curvature,
Expand Down Expand Up @@ -914,8 +912,6 @@ export ×,
representation_size,
retract,
retract!,
retract_fused,
retract_fused!,
riemannian_gradient,
riemannian_gradient!,
riemannian_Hessian,
Expand Down
2 changes: 1 addition & 1 deletion test/groups/general_unitary_groups.jl
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ include("group_utils.jl")
q2 = exp_lie(QU1, X)
X3 = log_lie(QU1, q2)
@test isapprox(QU1, p, X, X3)
q3 = exp_fused(QU1, p, X, 1.0)
q3 = Manifolds.exp_fused(QU1, p, X, 1.0)
@test isapprox(QU1, q, q3)

q3 = Ref(Quaternion(0.0))
Expand Down
2 changes: 1 addition & 1 deletion test/manifolds/circle.jl
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ using Manifolds: TFVector, CoTFVector
# this is an issue on Julia 1.6 but not later releases
M = Circle()
p = fill(0.0)
exp_fused!(M, p, p, [1.0], 2.0)
Manifolds.exp_fused!(M, p, p, [1.0], 2.0)
@test p fill(2.0)
parallel_transport_to!(M, p, p, [4.0], p)
@test p fill(4.0)
Expand Down
2 changes: 1 addition & 1 deletion test/manifolds/euclidean.jl
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ using FiniteDifferences
# this is an issue on Julia 1.6 but not later releases
for M in [Euclidean(), Euclidean(; parameter=:field)]
p = fill(0.0)
exp_fused!(M, p, p, [1.0], 2.0)
Manifolds.exp_fused!(M, p, p, [1.0], 2.0)
@test p fill(2.0)
parallel_transport_to!(M, p, p, [4.0], p)
@test p fill(4.0)
Expand Down
2 changes: 1 addition & 1 deletion test/manifolds/unitary_matrices.jl
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ end
r = exp(M, p, X)
X2 = log(M, p, r)
@test isapprox(M, p, X, X2)
r1 = exp_fused(M, p, X, 1.0)
r1 = Manifolds.exp_fused(M, p, X, 1.0)
@test isapprox(M, r, r1; atol=1e-10)

@testset "Projection" begin
Expand Down
4 changes: 2 additions & 2 deletions test/statistics.jl
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function exp!(::TestStatsSphere{N}, q, p, X; kwargs...) where {N}
return exp!(Sphere(N), q, p, X; kwargs...)
end
function Manifolds.exp_fused!(::TestStatsSphere{N}, q, p, X, t::Number; kwargs...) where {N}
return exp_fused!(Sphere(N), q, p, X, t; kwargs...)
return Manifolds.exp_fused!(Sphere(N), q, p, X, t; kwargs...)
end
function log!(::TestStatsSphere{N}, X, p, q; kwargs...) where {N}
return log!(Sphere(N), X, p, q; kwargs...)
Expand All @@ -54,7 +54,7 @@ function Manifolds.exp_fused!(
t::Number;
kwargs...,
) where {N}
return exp_fused!(Euclidean(N), q, p, X, t; kwargs...)
return Manifolds.exp_fused!(Euclidean(N), q, p, X, t; kwargs...)
end
function log!(::TestStatsEuclidean{N}, X, p, q; kwargs...) where {N}
return log!(Euclidean(N), X, p, q; kwargs...)
Expand Down

0 comments on commit acda8b7

Please sign in to comment.