Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to ManifoldsBase 1.0 #781

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

kellertuer
Copy link
Member

@kellertuer kellertuer commented Jan 25, 2025

This depends on JuliaManifolds/ManifoldsBase.jl#221 being merged.

Overall I went through all occurrences of exp and exp! and split/renamed them to expt and expt!, respectively, where necessary.
There are two tricky areas left

  • interaction with the MetricManifold, which should carefully be checked
  • interaction with solve_exp_ode where I can not yet see why they fail because the error messages basically kill my terminal in length.

Formerly this is breaking, because we drop support for ManifoldsBase 0.15?

Furthermore all occurrences of retract, retract_ and all its follow up functions need to be split for each and every retraction method on every manifold.

  • add deprecations for the renamed types from TVector to Tangentvector

@kellertuer kellertuer added the WIP Work in Progress (for a pull request) label Jan 25, 2025
@kellertuer kellertuer changed the title Adapt to ManifoldsBase 0.16 and split exp into exp and expt Adapt to ManifoldsBase 1.0 Jan 26, 2025
@mateuszbaran
Copy link
Member

retract rework is more or less done. I have some issues with OrdinaryDiffEq.jl failing to even precompile right now so that part will have to wait a bit. Next part is renaming and injectivity_radius.

@kellertuer
Copy link
Member Author

My rework from the weekend makes all tests pass, so after releasing 1.0, we only have to check for test coverage by now.

NEWS.md Show resolved Hide resolved
@kellertuer kellertuer added Ready-for-Review A label for pull requests that are feature-ready preview docs Add this label if you want to see a PR-preview of the documentation and removed WIP Work in Progress (for a pull request) labels Feb 5, 2025
@kellertuer
Copy link
Member Author

kellertuer commented Feb 5, 2025

This should be finished ± checking for code coverage after all the changes to exp/retr.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.52%. Comparing base (0c2a7b7) to head (bfd984f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
+ Coverage   96.45%   96.52%   +0.06%     
==========================================
  Files         127      127              
  Lines       11890    11957      +67     
==========================================
+ Hits        11469    11541      +72     
+ Misses        421      416       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellertuer
Copy link
Member Author

Docs are already fixed here locally, checking tutorials already. But will only push after I see how the tests are doing and maybe working on code cov there already.

@kellertuer
Copy link
Member Author

Raised number of ambiguities allowed to 35 – noticed that it is also 35 on 1.11; but we exclude 1.11 from testing ambiguities; so it did not error locally for me. Do we want to keep that exclusion? Do we want to keep the ambiguity test or is the one from Aqua enough? (I just do not remember the arguments maybe).

@mateuszbaran
Copy link
Member

Maybe let's keep the exclusion; it prevents spurious failures on CI when a new Julia version is released. The bump in allowed ambiguities should be OK. The Aqua test makes wider exclusions than ours so I'd prefer to keep both.

@kellertuer
Copy link
Member Author

Ok, just means that me running on 1.11 would not see this happening and only CI would fail. But I checked the new ambiguities and they look harmless.

@kellertuer
Copy link
Member Author

kellertuer commented Feb 7, 2025

We have code coverage – I even fixed a few previously uncovered lines, to slowly increase code cov here.

If it is ok, I would like to merge this and register a new version.

You can merge an register as well of course; for me it would be great in order to continue with the 3 PRs that depend on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants